code-mode: make pending frontiers generation-resumable#29399
Closed
cconger wants to merge 1 commit into
Closed
Conversation
cconger
force-pushed
the
cconger/code-mode-runtime-compact-03f1-pending-generations
branch
from
b140ec7 to
8eac740
Compare
This was referenced Jun 22, 2026
jif-oai
reviewed
Jun 22, 2026
| last_resumed_generation = Some(generation); | ||
| runtime_paused = false; | ||
| let _ = runtime_control_tx | ||
| .send(RuntimeControlCommand::Continue); |
Collaborator
There was a problem hiding this comment.
Can we only consume the frontier after Continue is successfully sent?
If the runtime has already dropped control_rx, this currently clears the frontier and returns Resumed even though execution never resumed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A pausable cell needs a stable pending frontier. Repeated observation must return the same frontier without advancing execution, and resume must target the exact frontier the caller observed.
What
PendingGeneration.AlreadyRunningfor an already-consumed generation and reject a future generation.Stack boundary
This PR establishes generation-safe pausing inside
SessionRuntime. Continuing and pausable cells still share too much of the Rust type surface here; #29400 separates their capabilities. This is not yet a host/core protocol change.Validation
just test -p codex-code-modeStack parent: #29290.